Reorder make_plots for EDMFSpherePlots and make comparison plot column widths equal
#3935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petebachant
force-pushed
the
fix-ci-plot-align
branch
from
ab6bea8 to
e8aed40
Compare
There was a problem hiding this comment.
Hi @petebachant! The code changes look good, but our buildkite CI pipeline can not run on a forked repository. Do you have permissions to create a branch in the repo directly?
I think the failing GHA test is unrelated to your PR.
I do as of this morning, so I will open up a new one. |
|
Superseded by #3941 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Resolves #3915
To-do
var_groups_zt, because it's confusing?Content
summary_comparison.pdffiles will now look like:I also added some print statements to log what happens in plotting. Let me know if that is not desired, or if I should use the logging macros or something. I see no other logging happening in
ci_plots.jl, so I'm assuming it's a convention to keep things quiet.